Repository navigation
Conversation
…ly tagged enum from sequence of 1 element (tag only)
After consuming the tag from the sequence the value (`()`) should be deserialzied from an empty sequence
failures(1):
newtype_unit
That path could be reached by deserialization of value:
- of newtype variant of internally tagged enum
- of content of adjacently tagged enum. So,
{ "content": [], "tag": ... } will be deserialized the same, as
{ "content": {}, "tag": ... } or
{ "content": null, "tag": ... }
- of field in the flatten struct
Mingun
commented
Oct 11, 2026
Comment on lines
+160
to
+176
|
|
||
| assert_de_tokens( | ||
| &value, | ||
| &[ | ||
| Token::Seq { len: Some(1) }, | ||
| Token::Str("NewtypeUnit"), // tag | ||
| Token::SeqEnd, | ||
| ], | ||
| ); | ||
| assert_de_tokens( | ||
| &value, | ||
| &[ | ||
| Token::Seq { len: Some(1) }, | ||
| Token::BorrowedStr("NewtypeUnit"), // tag | ||
| Token::SeqEnd, | ||
| ], | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
The same tests for unit struct currently at lines
serde/test_suite/tests/test_enum_internally_tagged.rs
Lines 210 to 225 in 6693a89
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That changed path could be reached by deserialization of value:
{ "content": [], "tag": ... }{ "content": {}, "tag": ... }{ "content": null, "tag": ... }See the playground which demonstrates the current behavior. Note, that tests with unit structs are all passed, but some tests with
()are not:This PR fixes this behavior. Note, that probably internally tagged enums, content of the adjacently tagged enums and content of flatten types must use different deserializers, but that change is out of scope of this PR.