ci: new CI - #644
Draft
alejandro-vaz wants to merge 8 commits into
Draft
ci: new CI#644alejandro-vaz wants to merge 8 commits into
alejandro-vaz wants to merge 8 commits into
Conversation
Collaborator
Author
|
surprisingly, it is faster than the old one, because we removed 5-10 minutes of doing nothing in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR remakes CI and simplifies it a great deal
it is a replacement for the
rust.ymlworkflowit adds two workflows:
checks.yml=> fast checks "everything is okay" for PRs. runs on PRs, merge queue, and manuallyperformance.yml=> deep benchmarking, runs on v2 push and manuallyit deliberately changes
tests/borsh.rs::round_trip_zstto have less elements so the miri test doesn't hang and reorders a block insrc/taggedlen.rsso that there is no warning emittednote: this PR is blocked by #631, and that's why checks currently fail
checks
checks has seven jobs:
in total, these jobs are more comprehensive than our current checks
it removes the old beta testing. argument: why have it when we have both stable and nightly?? what's the point exactly?? it's the same as saying we should test every rust version since the MSRV or every nightly commit
it also removes the old "abort all other checks if one fails" so you can discover all issues at the same time
estimated run time: 1-2 minutes, around 8-10x faster than our current checks, which is perfect for PRs
performance
three jobs:
running benchmarks simultaneously
estimated run time: 3-4 minutes, substantially faster than our current benchmarking because it executes in parallel