libservo: Expand documentation for WebView methods. - #45467
Merged
Conversation
WebView methods.WebView methods.
shubhamg13
approved these changes
Jun 8, 2026
mukilan
commented
Jun 8, 2026
| /// given `message`, and the embedder will be notified via | ||
| /// [`WebViewDelegate::notify_crashed`]. | ||
| /// | ||
| /// TODO: Describe the use case for this API? |
Member
Author
There was a problem hiding this comment.
@mrobinson I couldn't figure out the use case for this API as this is not used in servoshell. Is it used for testing?
Member
There was a problem hiding this comment.
I think this is unused actually. Let's skip documentation now and then please open a PR to remove it and the EmbedderToConstellationMessage::SendError variant as well.
mrobinson
approved these changes
Jun 8, 2026
| Panic(WebViewId, String, Option<String>), | ||
| /// A webview potentially gained focus for keyboard events. | ||
| /// If the boolean value is false, the webiew could not be focused. | ||
| /// If the boolean value is false, the webview could not be focused. |
Member
There was a problem hiding this comment.
Suggested change
| /// If the boolean value is false, the webview could not be focused. | |
| /// If the boolean value is false, the `WebView` could not be focused. |
Member
Author
There was a problem hiding this comment.
There were other instances in this enum's documentation where webview was used. I've changed those as well in fc1d832.
| /// given `message`, and the embedder will be notified via | ||
| /// [`WebViewDelegate::notify_crashed`]. | ||
| /// | ||
| /// TODO: Describe the use case for this API? |
Member
There was a problem hiding this comment.
I think this is unused actually. Let's skip documentation now and then please open a PR to remove it and the EmbedderToConstellationMessage::SendError variant as well.
Also add documention for few more types in `webview_delegate.rs`. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
mukilan
force-pushed
the
push-yytyzrktrkmu
branch
from
June 8, 2026 10:51
2b3e9e2 to
fc1d832
Compare
mukilan
enabled auto-merge
June 8, 2026 10:56
niyabits
pushed a commit
to niyabits/servo
that referenced
this pull request
Jun 11, 2026
Also add documentation for few more types in `webview_delegate.rs`. Testing: Not needed as there are no code changes. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add documentation for few more types in
webview_delegate.rs.Testing: Not needed as there are no code changes.