script: JSContextify most of webgpu - #45552
Merged
Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
marked this pull request as ready for review
June 10, 2026 12:20
TimvdLippe
requested changes
Jun 10, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Most of it looks good, but the realm code should use CurrentRealm instead so that it can use the existing promise methods.
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
Ah taht was the missing thing I didn't know about. I added a couple more CurrentRealm in it. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves from CanGc to JSContext for most of dom/webgpu with exceptions where complications arose.
Special care should taken to review the following:
Testing: Describe the new automated tests that cover this change or explain why it doesn't require tests.
Fixes: Link to an issue this pull request fixes or remove this line if there is no issue.
Edit: The merged version does not have the Promise::new_in_current_realm2 as it was replaced with CurrentRealm.