servoshell: Use Window.current_monitor() in HeadedWindow.set_fullscreen to show fullscreen on current window - #45556
Merged
jdm merged 2 commits intoJun 12, 2026
Conversation
Signed-off-by: rhit-kapilaar <kapilaar@rose-hulman.edu>
Signed-off-by: rhit-kapilaar <kapilaar@rose-hulman.edu>
rhit-kapilaar
force-pushed
the
rhit-kapilaar/full-screen-on-multiple-screens
branch
from
June 12, 2026 12:29
db1beea to
f1acf71
Compare
jdm
enabled auto-merge
June 12, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure the servoshell window is rendered in fullscreen in current active screen, we need to get the current monitor
on runtime every time set_fullscreen is run. However, currently it uses the 'monitor' field of HeadedWindow struct which was just defined once at app startup. This prevents servoshell running on fullscreen on other monitors apart from the one at start. This change removes the monitor field from HeadedWindow and uses Window.current_monitor() in set_fullscreen function to get the current monitor at runtime and then display window on fullscreen on that monitor.
Testing: Although I am not fully certain, since this is just a small fix for servoshell, it doesn't require any additional testing methods since there aren't any tests for servoshell.
Fixes: #45488