script: Configure cx context for all HTMLElement interface bindings - #45673
Merged
Conversation
Signed-off-by: Ivo Murrell <ivo@cherry.computer>
Signed-off-by: Ivo Murrell <ivo@cherry.computer>
Signed-off-by: Ivo Murrell <ivo@cherry.computer>
Signed-off-by: Ivo Murrell <ivo@cherry.computer>
Taym95
approved these changes
Jun 14, 2026
Taym95
enabled auto-merge
June 14, 2026 14:30
TG199
pushed a commit
to TG199/servo
that referenced
this pull request
Jun 21, 2026
…gs (servo#45673) Move all the bindings for `HTMLElement` and its child interfaces to use `&mut JSContext`, including setters that were previously implicitly using the `cx` setting. Testing: it compiles Part of servo#42638 --------- Signed-off-by: Ivo Murrell <ivo@cherry.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all the bindings for
HTMLElementand its child interfaces to use&mut JSContext, including setters that were previously implicitly using thecxsetting.Testing: it compiles
Part of #42638