Skip to content

script: Pass &mut JSContext to throw_dom_exception - #45678

Merged
TimvdLippe merged 5 commits into
servo:mainfrom
TimvdLippe:cx-throw-dom-exception
Jun 14, 2026
Merged

script: Pass &mut JSContext to throw_dom_exception#45678
TimvdLippe merged 5 commits into
servo:mainfrom
TimvdLippe:cx-throw-dom-exception

Conversation

@TimvdLippe

Copy link
Copy Markdown
Contributor

Part of #40600

Testing: it compiles

@TimvdLippe

Copy link
Copy Markdown
Contributor Author

Built on top of #45674

Part of servo#40600

Testing: it compiles

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
@TimvdLippe
TimvdLippe force-pushed the cx-throw-dom-exception branch from cd392fb to e84ea1c Compare June 14, 2026 17:45
@TimvdLippe
TimvdLippe marked this pull request as ready for review June 14, 2026 17:45
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 14, 2026
Comment thread components/script/dom/bindings/error.rs Outdated
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jun 14, 2026
Co-authored-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 14, 2026
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
@TimvdLippe
TimvdLippe enabled auto-merge June 14, 2026 19:45
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
@TimvdLippe
TimvdLippe added this pull request to the merge queue Jun 14, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 14, 2026
Merged via the queue into servo:main with commit d1c1924 Jun 14, 2026
31 checks passed
@TimvdLippe
TimvdLippe deleted the cx-throw-dom-exception branch June 14, 2026 23:43
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 14, 2026
TG199 pushed a commit to TG199/servo that referenced this pull request Jun 21, 2026
Part of servo#40600

Testing: it compiles

---------

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>
Co-authored-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants