android: Remove unused code - #45712
Merged
Merged
Conversation
Signed-off-by: veyndan <veyndan@gmail.com>
TimvdLippe
approved these changes
Jun 15, 2026
TG199
pushed a commit
to TG199/servo
that referenced
this pull request
Jun 21, 2026
To aid with the migration of these classes to Kotlin (see servo#45640), this commit removes unused code from these classes so they don't have to be translated. Even though `takeScreenShotOfWebPage` was deliberately unused, it's unclear if we'd ever want to use this in the future nor if it'd take this form (e.g., we migrate to Compose UI). Since it's all saved in the git history anyway, we can safely remove it and retrieve it again if we want. Testing: There are no automated tests for Android. Signed-off-by: veyndan <veyndan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To aid with the migration of these classes to Kotlin (see #45640), this commit removes unused code from these classes so they don't have to be translated.
Even though
takeScreenShotOfWebPagewas deliberately unused, it's unclear if we'd ever want to use this in the future nor if it'd take this form (e.g., we migrate to Compose UI). Since it's all saved in the git history anyway, we can safely remove it and retrieve it again if we want.Testing: There are no automated tests for Android.