Skip to content

script: Mute iframe load events if iframe load event is ongoing. - #45883

Merged
jdm merged 1 commit into
servo:mainfrom
jdm:mute-iframe-load
Jun 23, 2026
Merged

script: Mute iframe load events if iframe load event is ongoing.#45883
jdm merged 1 commit into
servo:mainfrom
jdm:mute-iframe-load

Conversation

@jdm

@jdm jdm commented Jun 22, 2026

Copy link
Copy Markdown
Member

This prevents unexpected load events if particular navigations are triggered during an iframe's existing load event.

Testing: New passing test.
Part of #43149

@jdm
jdm requested a review from gterzian as a code owner June 22, 2026 13:10
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 22, 2026
Comment thread components/script/dom/html/htmliframeelement.rs Outdated
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jun 22, 2026
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm
jdm force-pushed the mute-iframe-load branch from 1f339aa to 7dae72b Compare June 23, 2026 03:27
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 23, 2026
@jdm
jdm enabled auto-merge June 23, 2026 03:27
@jdm
jdm added this pull request to the merge queue Jun 23, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 23, 2026
Merged via the queue into servo:main with commit ee57dd2 Jun 23, 2026
34 checks passed
@jdm
jdm deleted the mute-iframe-load branch June 23, 2026 04:12
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants