webcrypto: Add error messages for webcrypto crate. - #46478
Merged
Conversation
Related issue: servo#40756 Signed-off-by: eachra-bawn <mulhalloisin@gmail.com>
kkoyung
requested changes
Jul 13, 2026
kkoyung
left a comment
Member
There was a problem hiding this comment.
Thanks! We have many missing error messages in WebCrypto that need to be added.
Some suggested wording is provided below.
Signed-off-by: eachra-bawn <mulhalloisin@gmail.com>
Signed-off-by: eachra-bawn <mulhalloisin@gmail.com>
kkoyung
approved these changes
Jul 14, 2026
kkoyung
left a comment
Member
There was a problem hiding this comment.
Everything looks good now. Thanks!
6 tasks
pull Bot
pushed a commit
to Haofei/servo
that referenced
this pull request
Jul 22, 2026
… crates. (servo#46699) As agreed on [Zulip](https://servo.zulipchat.com/#narrow/channel/263398-general/topic/Expectation.20for.20error.20messages.20in.20PRs), we've been asking contributors to add error messages to new uses of the Error enum in their PRs. To reduce inconsistency in reviews, I propose a ratchet mechanism in our test-tidy checks. By adding a list of explicit counts of allowed exceptions per file, we can prevent introducing new uses in each file and lower the number of allowed exceptions every time a PR like servo#46478 is opened. Testing: New addition to test-tidy. Fixes: part of servo#40756 Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #40756
Testing: No new tests.