layout: Treat <button> as a widget - #46536
Merged
Merged
Conversation
|
🔨 Triggering try run (#29430341975) for Linux (WPT) |
|
Test results for linux-wpt from try job (#29430341975): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (23)
Stable unexpected results (7)
|
|
|
Loirooriol
force-pushed
the
button-widget
branch
from
July 15, 2026 17:38
c3b7fd9 to
b44c20b
Compare
|
🔨 Triggering try run (#29438099192) for Linux (WPT) |
|
Test results for linux-wpt from try job (#29438099192): Flaky unexpected result (45)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#29438099192) succeeded. |
For example, a `<button>` with `display: block` will no longer stretch by default, and a button with `display: inline` will be atomic. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
force-pushed
the
button-widget
branch
from
July 15, 2026 18:47
b44c20b to
fc94799
Compare
Loirooriol
marked this pull request as ready for review
July 15, 2026 18:51
|
🔨 Triggering try run (#29442285252) for Linux (WPT) |
|
Test results for linux-wpt from try job (#29442285252): Flaky unexpected result (40)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#29442285252) succeeded. |
mrobinson
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, a
<button>withdisplay: blockwill no longer stretch by default, and a<button>withdisplay: inlinewill be atomic.Note we were always forcing widgets to behave as having a
flow-rootinner display type. That wouldn't be correct for<button>, so introduce an exception.Testing: Some tests pass