script: Mechanically migrate more to reflect_dom_object_with_proto - #46593
Merged
Conversation
As a cleanup follow-up to the migration to pass `&mut JSContext`, this PR is the result of applying the following regex replacement to the codebase: Before: ``` Ok\(reflect_dom_object_with_proto_and_cx\((([^<]|\n)+),\n\s+?cx,\n\s+?\)\) ``` After: ``` Ok(reflect_dom_object_with_proto(cx, $1)) ``` Part of servo#40600 Testing: it compiles Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
migrate-mechanically-ok
branch
from
July 17, 2026 14:43
94ae185 to
44ec20e
Compare
Narfinger
approved these changes
Jul 17, 2026
Narfinger
left a comment
Contributor
There was a problem hiding this comment.
If it compiles it works. My favorite mantra.
kkoyung
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a cleanup follow-up to the migration to pass
&mut JSContext, this PR is the result of applying the following regex replacement to the codebase:Before:
After:
Part of #40600
Testing: it compiles