Skip to content

script: Reduce rooting in serialization of DOMQuad - #46598

Merged
jdm merged 1 commit into
servo:mainfrom
yezhizhen:root
Jul 18, 2026
Merged

script: Reduce rooting in serialization of DOMQuad#46598
jdm merged 1 commit into
servo:mainfrom
yezhizhen:root

Conversation

@yezhizhen

@yezhizhen yezhizhen commented Jul 18, 2026

Copy link
Copy Markdown
Member

Instead of using JS binding function to pass to closure which creates new root, directly use the Dom field.
Reduces 4 roots per serialize call.

Part of #34464

Testing: Covered by existing tests.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
@yezhizhen
yezhizhen requested a review from gterzian as a code owner July 18, 2026 00:30
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 18, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 18, 2026
@jdm
jdm added this pull request to the merge queue Jul 18, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 18, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 18, 2026
@jdm
jdm added this pull request to the merge queue Jul 18, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 18, 2026
Merged via the queue into servo:main with commit c3414c7 Jul 18, 2026
43 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 18, 2026
@yezhizhen
yezhizhen deleted the root branch July 18, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants