indexeddb: Handle schema changes asynchronously - #46615
Merged
jdm merged 4 commits intoJul 21, 2026
Merged
Conversation
|
🔨 Triggering try run (#29647877790) for Linux (WPT) |
|
Test results for linux-wpt from try job (#29647877790): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#29647877790) succeeded. |
mrobinson
marked this pull request as draft
July 18, 2026 17:43
Member
Author
|
Marking this one as a draft as it still needs a bit more work. |
mrobinson
force-pushed
the
indexeddb-schema-operation-async-stream
branch
from
July 19, 2026 14:00
1093bb5 to
321ba67
Compare
mrobinson
marked this pull request as ready for review
July 19, 2026 14:01
Member
Author
|
This is ready for review. it's 3 very-related changes (reviewable by commit) and one WPT expectations update. With this change the IndexedDB tests are very stable on my system (with a few unrelated flakes that I will continue to debug). |
Previously schema changes were sent as synchronous operations, but those happen on a different thread than asynchronous operations, which meant they could race. This change routes schema changes to the asynchronous IndexedDB path so that they can be handled in a consistent order with other asynchronous operations. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
This allows properly handling errors that occur in the backend during schema operations (now asynchronous). These are handled by aborting the transaction. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
Abort should not happen when transactions unresolved. Instead they should be queued (like the commit callbacks) and executed once the transaction itself finishes. This eliminates flakiness that can happen when the abort message arrives before or after the asynchronous transaction happens. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
Signed-off-by: Martin Robinson <martin@abandonedwig.info>
mrobinson
force-pushed
the
indexeddb-schema-operation-async-stream
branch
from
July 19, 2026 14:03
321ba67 to
cc702a3
Compare
Member
Author
|
Remaining flakes are handled by #46636. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously schema changes were sent as synchronous operations, but those
happen on a different thread than asynchronous operations, which meant
they could race. This change routes schema changes to the asynchronous
IndexedDB path so that they can be handled in a consistent order with
other asynchronous operations.
Testing: This fixes some WPT subtests and solves some flakiness issues.
Fixes: #43776.
Fixes: #45919.
Fixes: #43823.