script: Reduce GC-rooting in NodeList - #46664
Merged
Merged
Conversation
Pass `&JsContext` in a few more places in order to use `*_no_gc` APIs. This is a follow-up to servo#44435 Signed-off-by: Simon Sapin <simon@igalia.com>
sagudev
reviewed
Jul 20, 2026
| }, | ||
|
|
||
| 'NodeList': { | ||
| 'cx_no_gc': ['Item', 'IndexedGetter'], |
Member
There was a problem hiding this comment.
is
Suggested change
| 'cx_no_gc': ['Item', 'IndexedGetter'], | |
| 'no_gc': ['Item', 'IndexedGetter'], |
not enough?
Member
Author
There was a problem hiding this comment.
Indeed it is, I just didn’t realize that was a thing
Gae24
reviewed
Jul 20, 2026
| pub(crate) fn iter<'a>( | ||
| &'a self, | ||
| cx: &'a JSContext, | ||
| ) -> impl Iterator<Item = DomRoot<Node>> + 'a { |
Contributor
There was a problem hiding this comment.
For a follow-up would be worth to avoid rooting the items, by switching to UnrootedDom?
Member
Author
There was a problem hiding this comment.
Good point, done. Though I found something worrying along the way: #46665
Signed-off-by: Simon Sapin <simon@igalia.com>
NodeRangeNodeList
Signed-off-by: Simon Sapin <simon@igalia.com>
sagudev
approved these changes
Jul 21, 2026
| fn matching_links( | ||
| links: &NodeList, | ||
| fn matching_links<'a>( | ||
| cx: &'a JSContext, |
Member
There was a problem hiding this comment.
Suggested change
| cx: &'a JSContext, | |
| cx: &'a NoGC, |
Signed-off-by: Simon Sapin <simon@igalia.com>
SimonSapin
enabled auto-merge
July 21, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
&JsContextin a few more places in order to use*_no_gcAPIs. This is a follow-up to #44435Testing: expecting no change to existing test results