Skip to content

script: Implement a readonly version of CSSFontFeatureValuesRule - #46728

Merged
simonwuelker merged 4 commits into
servo:mainfrom
simonwuelker:cssom-font-feature-values
Jul 23, 2026
Merged

script: Implement a readonly version of CSSFontFeatureValuesRule#46728
simonwuelker merged 4 commits into
servo:mainfrom
simonwuelker:cssom-font-feature-values

Conversation

@simonwuelker

Copy link
Copy Markdown
Member

So far the interface has been a complete stub, now we expose all the available info but don't allow modifying the underlying @font-feature-values rule yet.

Testing: New tests start to pass

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker
simonwuelker requested a review from gterzian as a code owner July 22, 2026 20:33
@simonwuelker simonwuelker added the A-content/dom Interacting with the DOM from web content label Jul 22, 2026
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 22, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker
simonwuelker force-pushed the cssom-font-feature-values branch from ea7514e to 463039c Compare July 22, 2026 20:45
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker
simonwuelker force-pushed the cssom-font-feature-values branch from 4000de5 to e5cd6c7 Compare July 23, 2026 00:51
Comment thread components/script/dom/css/cssfontfeaturevaluesmap.rs
Comment thread components/script/dom/css/cssfontfeaturevaluesmap.rs Outdated
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 23, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 23, 2026
@simonwuelker
simonwuelker enabled auto-merge July 23, 2026 10:00
@simonwuelker
simonwuelker added this pull request to the merge queue Jul 23, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 23, 2026
Merged via the queue into servo:main with commit 46eb1bc Jul 23, 2026
34 checks passed
@simonwuelker
simonwuelker deleted the cssom-font-feature-values branch July 23, 2026 12:00
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-content/dom Interacting with the DOM from web content S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants