base: Rework UTF-8/16/32 offset/length wrapper types - #46742
Merged
Conversation
SimonSapin
requested review from
Loirooriol,
gterzian and
mrobinson
as code owners
July 23, 2026 11:07
* Rename `Utf*CodeUnitLength` to `Utf*CodeUnits` since it can be used for offsets as well as lengths * Move free function conversions to methods * Optimize conversions by matching UTF-8 bit patterns instead of decoding UTF-8 to `char`s. Signed-off-by: Simon Sapin <simon@igalia.com>
mrobinson
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utf*CodeUnitLengthtoUtf*CodeUnitssince it can be used for offsets as well as lengthschars.Following up on #46698
Testing: expecting no change to existing tests