script: Implement async FileSystemEntry.getParent() success callback - #46879
Merged
Conversation
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61622) with upstreamable changes. |
yezhizhen
marked this pull request as draft
July 30, 2026 01:45
yezhizhen
marked this pull request as ready for review
July 30, 2026 07:20
Gae24
approved these changes
Jul 30, 2026
Gae24
left a comment
Contributor
There was a problem hiding this comment.
Have you checked the test on other browsers? Not sure how the parent from a synthetic DataTransfer should be handled.
Member
Author
It works well for Safari and FF. For Chromium, webkitGetAsEntry always return null on synthetic DataTransfer entries, which is not spec compliant. (But Chromium already has extremely low passing rate on entire https://wpt.fyi/results/entries-api?label=master&label=experimental&aligned) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Added an automated test unlike those existing manual ones. The major difference is, it does not require OS drag-and-drop support, but still tests the full DnD script path programatically.
Part of #45653