script: Remove duplicated incorrect version of FormControl::is_listed() - #46094
Merged
Conversation
…d()` There were two versions of this check: `FormControl::is_listed()` and `HTMLElement::is_element_listed()`. The latter was incomplete and incorrect. Both were used inconsistently. This led to non-specification aligned behavior when moving form-associated elements in the page, ultimately leading to a panic. This change fixes that issue by making `FormControl::is_listed()` rely on `HTMLElement::is_element_listed()`, matching the specification more closely. Signed-off-by: Martin Robinson <martin@abandonedwig.info>
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#60971) with upstreamable changes. |
jdm
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two versions of this check:
FormControl::is_listed()andHTMLElement::is_element_listed(). The latter was incomplete andincorrect. Both were used inconsistently. This led to non-specification
aligned behavior when moving form-associated elements in the page,
ultimately leading to a panic. This change fixes that issue by making
FormControl::is_listed()rely onHTMLElement::is_element_listed(),matching the specification more closely.
Testing: This change adds a WPT crash test, though the crash only reproduces inconsistently.
Fixes: #45947.