script: Implement importKey and exportKey operation of Ed448 - #46141
Merged
Conversation
Start adding Ed448 support to WebCrypto API implementation, using the ed448-goldilocks crate. ed448-goldilocks 0.14.0-pre.15 is used to match the version of the elliptic-curve crate. We will bump it to the next stable release when it is available, along with issue 45823. This patch implements the importKey and exportKey operations of Ed448, along with the serialization of Ed448 handles in `CryptoKey`. Note that some failed WPT tests on wrapping/unwrapping keys appears because they require the sign and verify operations of Ed448, which have not yet been implemented. Specification: <https://wicg.github.io/webcrypto-secure-curves/#ed448> Testing: Covered by WPT tests in `WebCryptoAPI/import_export` directory Part-of: 46140 Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
TimvdLippe
approved these changes
Jul 1, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start adding Ed448 support to WebCrypto API implementation, using the ed448-goldilocks crate.
We use
ed448-goldilocks 0.14.0-pre.15to match the version of the elliptic-curve crate. We will bump it to the next stable release when it is available, along with issue #45823.This patch implements the importKey and exportKey operations of Ed448, along with the serialization of Ed448 handles in
CryptoKey.Note that some failed WPT tests on wrapping/unwrapping keys appears because they require the sign and verify operations of Ed448, which have not yet been implemented.
Specification: https://wicg.github.io/webcrypto-secure-curves/#ed448
Testing: Covered by WPT tests in
WebCryptoAPI/import_exportdirectoryPart-of: #46140