script: Switch GetClientRect and dirty_all_nodes to use unrooted iterators - #46144
Merged
Conversation
Narfinger
force-pushed
the
client-rect-and-similar
branch
from
July 2, 2026 08:46
073ae17 to
2179225
Compare
|
🔨 Triggering try run (#28577875220) for Linux (WPT) |
|
|
Narfinger
force-pushed
the
client-rect-and-similar
branch
from
July 2, 2026 13:26
2179225 to
03be1ca
Compare
Narfinger
marked this pull request as ready for review
July 7, 2026 06:07
Narfinger
force-pushed
the
client-rect-and-similar
branch
2 times, most recently
from
July 7, 2026 11:23
0246ab1 to
9912d72
Compare
Gae24
approved these changes
Jul 9, 2026
| } | ||
|
|
||
| pub(crate) fn search(mut self) -> Option<DomRoot<Element>> { | ||
| pub(crate) fn search(mut self, no_gc: &NoGC) -> Option<DomRoot<Element>> { |
Contributor
There was a problem hiding this comment.
As a follow-up we should investigate if search and maybe_search_in_containing_focus_navigation_scope could avoid returning a rooted Element.
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
client-rect-and-similar
branch
from
July 10, 2026 09:34
18b2af2 to
dc643a6
Compare
jdm
reviewed
Jul 10, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jdm
approved these changes
Jul 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 14, 2026
jdm
reviewed
Jul 14, 2026
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
Done. |
jdm
enabled auto-merge
July 15, 2026 07:19
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 15, 2026
Contributor
Author
|
Windows CI just flaky? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of these methods can be called a lot on some websites.
This uses the unrooted iterators variety for their loop.
Includes #46143
Testing: NoGC only needs compilation to be tested and DocumentFragment::ChildElementCount is hopefully tested by WPT.