android: Convert navigation bar to Compose UI - #46164
Merged
Merged
Conversation
Signed-off-by: veyndan <veyndan@gmail.com>
veyndan
commented
Jul 1, 2026
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <item type="id" name="cancel_menu_item" /> | |||
Contributor
Author
There was a problem hiding this comment.
Creating IDs manually like this is usually a bit odd, but I did it because MainActivity still needs IDs to "dispatch actions". We probably don't need this "dispatch action" logic, and the code should probably be refactored to remove the usage of IDs. In order to keep this PR focused though, this is a stopgap which will be removed in a future PR.
yezhizhen
reviewed
Jul 2, 2026
| ) | ||
| NavigationBarItem( | ||
| selected = false, | ||
| onClick = { dispatchAction(if (isRefreshingState.value) R.id.cancel_menu_item else R.id.refresh_menu_item) }, |
Member
There was a problem hiding this comment.
Is it possible to extract these common if else into selecting one out of two NavigationBarItem, instead of setting content&handler internally?
Signed-off-by: veyndan <veyndan@gmail.com>
yezhizhen
approved these changes
Jul 3, 2026
| ) | ||
| NavigationBarItem( | ||
| selected = false, | ||
| onClick = { dispatchAction(if (isRefreshingState.value) R.id.cancel_menu_item else R.id.refresh_menu_item) }, |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the toolbar on larger screens, the navigation bar couldn't be migrated piecemeal, since the Android View enforces an all or nothing approach.
Testing: There are no automated tests for Android.
Fixes: Part of #45715.