Skip to content

script: Pass &mut JSContext to get_in_memory_bytes - #46166

Merged
TimvdLippe merged 1 commit into
servo:mainfrom
kunalmohan:45963-js-context
Jul 1, 2026
Merged

script: Pass &mut JSContext to get_in_memory_bytes#46166
TimvdLippe merged 1 commit into
servo:mainfrom
kunalmohan:45963-js-context

Conversation

@kunalmohan

Copy link
Copy Markdown
Contributor

As the title says. This removes a section of unsafe code from the mentioned function.

Testing: Existing tests should cover this functionality
Fixes: #45963

Signed-off-by: Kunal Mohan <kunalmohan99@gmail.com>
@kunalmohan
kunalmohan requested a review from gterzian as a code owner July 1, 2026 18:20
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 1, 2026

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 1, 2026
@TimvdLippe
TimvdLippe added this pull request to the merge queue Jul 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 1, 2026
Merged via the queue into servo:main with commit 82fda83 Jul 1, 2026
34 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 1, 2026
@kunalmohan
kunalmohan deleted the 45963-js-context branch July 2, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass &mut JSContext to get_in_memory_bytes

3 participants