mach: Add necessary space between command-line arguments windows.py and handle GStreamer failed installation - #46181
Merged
Merged
Conversation
mrobinson
requested changes
Jul 2, 2026
mrobinson
left a comment
Member
There was a problem hiding this comment.
Looks good with a tiny change, but please use the default commit template when submitting PRs to Servo.
Contributor
Author
|
The format has been changed to the default format. Thank you！: ) |
Signed-off-by: dDostalker <146743193+dDostalker@users.noreply.github.com>
Co-authored-by: Martin Robinson <martin@abandonedwig.info> Signed-off-by: dDostalker <dDostalker@foxmail.com>
mrobinson
approved these changes
Jul 3, 2026
windows.py and handle failed installation
windows.py and handle failed installationwindows.py and handle GStreamer failed installation
mrobinson
enabled auto-merge
July 3, 2026 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
windows.pythere was no space between....msi"andTARGETDIR; and instead they were joined into a single string.msiexectreats this entire string as the path to the MSI file and attempts to open it. At the same time, the issue where the "is gstreamer installed" check only looked forffi-7.dll(the runtime), preventing the installation of the devel package if the runtime package was already present—has been fixed.Testing: This part of the Servo bootstrap does not really have testing coverage.
Fixes: None