Skip to content

script: Remove FromJSValConvertible::from_jsval - #46191

Merged
Gae24 merged 3 commits into
servo:mainfrom
Gae24:drop-raw-from-jsval
Jul 3, 2026
Merged

script: Remove FromJSValConvertible::from_jsval#46191
Gae24 merged 3 commits into
servo:mainfrom
Gae24:drop-raw-from-jsval

Conversation

@Gae24

@Gae24 Gae24 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Testing: It compiles
Part of #40600

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@Gae24
Gae24 requested a review from gterzian as a code owner July 2, 2026 09:09
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 2, 2026

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see all those temp_cx gone! 🎉

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 2, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 2, 2026
@Gae24
Gae24 added this pull request to the merge queue Jul 2, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 2, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 2, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@servo-highfive servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Jul 3, 2026
@Gae24
Gae24 enabled auto-merge July 3, 2026 05:38
@Gae24
Gae24 added this pull request to the merge queue Jul 3, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 3, 2026
Merged via the queue into servo:main with commit 615be1e Jul 3, 2026
30 of 31 checks passed
@Gae24
Gae24 deleted the drop-raw-from-jsval branch July 3, 2026 08:13
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 3, 2026
jdm pushed a commit to jdm/mozjs that referenced this pull request Jul 9, 2026
Testing: It compiles
Servo PR: servo/servo#46191
Fixes: servo#749

---------

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants