Update stylo (enable scrollbar-color/scrollbar-width behind a pref for the servo engine) - #46256
Merged
Merged
Conversation
UMCEKO
force-pushed
the
stylo-scrollbar-props
branch
from
July 3, 2026 20:52
162ee59 to
81c6bdf
Compare
|
🔨 Triggering try run (#28683769033) for Linux (WPT) |
Contributor
|
(lint error can be ignored - that's just because you've referenced your fork of stylo and will go away once we merge the PR and change the reference back to |
Contributor
Author
ah got it i thought i messed something up lol |
|
Test results for linux-wpt from try job (#28683769033): Flaky unexpected result (40)
Stable unexpected results that are known to be intermittent (22)
|
|
✨ Try run (#28683769033) succeeded. |
Loirooriol
approved these changes
Jul 3, 2026
Loirooriol
left a comment
Contributor
There was a problem hiding this comment.
To avoid the warning, you could use rev = "refs/pull/413/head".
Contributor
If you have a PR open, that using the git rev (commit id) from the branch with the |
nicoburns
force-pushed
the
stylo-scrollbar-props
branch
from
July 3, 2026 23:40
81c6bdf to
0d7bbc9
Compare
…ngine) Points stylo at servo/stylo#413 for CI validation; to be repointed to stylo main once that PR merges. Signed-off-by: Umut Cevdet Koçak <umutcevdetkocak@gmail.com>
Loirooriol
force-pushed
the
stylo-scrollbar-props
branch
from
July 3, 2026 23:40
0d7bbc9 to
980e2b0
Compare
nicoburns
marked this pull request as ready for review
July 3, 2026 23:41
Loirooriol
enabled auto-merge
July 3, 2026 23:41
Psychpsyo
pushed a commit
to Psychpsyo/stylo
that referenced
this pull request
Jul 5, 2026
Both css-scrollbars-1 properties were gated `engine="gecko"` in `longhands.toml`, but their value types and parsers are engine-neutral. Removing the gate lets the servo configuration parse, compute, and expose them (`scrollbar-color` in inherited_ui, `scrollbar-width` in ui), so servo-engine consumers can implement css-scrollbars-1 rendering. Unblocks blitz scrollbars PR. Servo companion: servo/servo#46256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the stylo dependency at servo/stylo#413, which gates
scrollbar-colorandscrollbar-widthbehind thelayout.unimplementedpref for the servo engine. The pref is disabled in Servo, so no behavior change is expected. This PR exists to let CI validate the stylo change; it will be repointed to stylo main once servo/stylo#413 merges.Testing: No behavior change expected (the pref is disabled in Servo); existing CI/WPT coverage validates that.