android: Support Android 10 and unify API-level definition - #46308
Merged
Conversation
Unify the minimum supported API-level definition, by defining it in a new servo.properties file that is read by both gradle and mach, so that we only need to change the value in one place. Downgrade the value to `29` (android 10), which was released in 2019 and covers 91% of devices according to https://apilevels.com/. Android 9 would also be possible for arm64, however the emulator smoketest crashes on x86_64 due to usage of the `open` syscall, which that emulator apparently doesn't like. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the minimum supported API-level definition, by defining it in a new servo.properties file that is read by both gradle and mach, so that we only need to change the value in one place. Downgrade the value to
29(android 10), which was released in 2019 and covers 91% of devices according to https://apilevels.com/ (vs. 87% for android 11).Android 9 would also be possible for arm64, however the emulator smoketest crashes on x86_64 due to usage of the
opensyscall, which that emulator apparently doesn't like.Testing: Covered by
./mach smoketest(mach try android)