layout: Clear laid out fragments of descendants when content is replaced - #46314
Merged
Conversation
…laced A dynamic change of the `content` property can turn a non-replaced element into replaced. In that case, it's possible that the contents were laid out previously, and now they will be skipped. The problem was that we were still caching the results from the previous layout in some cases. Thus, script queries like `getComputedStyle` could return the wrong value, or Servo could crash. Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com>
|
🔨 Triggering try run (#28812017106) for Linux (WPT) |
mrobinson
approved these changes
Jul 6, 2026
mrobinson
enabled auto-merge
July 6, 2026 17:55
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61099) with upstreamable changes. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#61099) title and body. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 6, 2026
|
Test results for linux-wpt from try job (#28812017106): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#28812017106) succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dynamic change of the
contentproperty can turn a non-replaced element into replaced. In that case, it's possible that the contents were laid out previously, and now they will be skipped.The problem was that we were still caching the results from the previous layout in some cases. Thus, script queries like
getComputedStylecould return the wrong value, or Servo could crash.Testing: Adding a crashtest and a testharness one
Fixes: #46023