script: Don't store rooted values inside ElementInternals and FormData - #46349
Merged
Conversation
Gae24
marked this pull request as draft
July 8, 2026 08:39
Gae24
force-pushed
the
non-rooted-form-data
branch
from
July 8, 2026 09:19
13fbdbf to
c29ff7d
Compare
Gae24
marked this pull request as ready for review
July 8, 2026 09:19
Narfinger
reviewed
Jul 8, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Gae24
force-pushed
the
non-rooted-form-data
branch
from
July 9, 2026 08:29
c29ff7d to
82ab20a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
ElementInternalsandFormDatacould potentially own rooted values, to fix this, an unrooted variant was added.Testing: It compiles
Part of #39139