android: Convert progress indicator to Compose UI - #46353
Conversation
| style="@android:style/Widget.Material.EditText" | ||
| android:layout_width="0dp" | ||
| android:layout_height="match_parent" | ||
| android:layout_height="wrap_content" |
There was a problem hiding this comment.
This is required, otherwise the field is clipped vertically when the progress indicator is visible. It's a bit counterintuitive. It's been so long since I've dealt extensively with Android Views, so I'm not really sure why this works, just that it does.
There was a problem hiding this comment.
I guess this no longer matters anyway after full migration in the future.
Might be some weird interaction with legacy layout.
Signed-off-by: veyndan <veyndan@gmail.com>
480c56f to
f1fb604
Compare
| if (isRefreshingState.value) { | ||
| CircularProgressIndicator( | ||
| modifier = Modifier | ||
| .padding(end = 10.dp) |
There was a problem hiding this comment.
Interesting. There's no concept of margin but only padding in Compose.
There was a problem hiding this comment.
Yeah it depends on which order around the padding and size is. If the function calls were flipped, then it acts like padding.
| style="@android:style/Widget.Material.EditText" | ||
| android:layout_width="0dp" | ||
| android:layout_height="match_parent" | ||
| android:layout_height="wrap_content" |
There was a problem hiding this comment.
I guess this no longer matters anyway after full migration in the future.
Might be some weird interaction with legacy layout.
Testing: There are no automated tests for Android.
Fixes: Part of #45715.