Skip to content

Correct Victoria alliance effect EN translation via adding a correction layer to i18n - #499

Open
YuriRestia wants to merge 1 commit into
sganggs:masterfrom
YuriRestia:fix/correction-victoria-bond-trait
Open

YuriRestia wants to merge 1 commit into
sganggs:masterfrom
YuriRestia:fix/correction-victoria-bond-trait

Conversation

@YuriRestia

Copy link
Copy Markdown
Contributor

Change type

  • fix
  • feature
  • docs
  • refactor
  • test
  • chore

Description

  • Change: The official EN client text for the Victoria Alliance's 6-operator effect reads as a flat bonus: "All [Victoria] Operators carrying equipment gain +50% ATK, or +80% ATK if equipment is upgraded". The Chinese text and the engine both apply it per item. This PR adds a small corrections layer to tools/build-i18n.mjs. It is tried before the official texts, so a wrong official line can be fixed without editing the official data.
    • tools/i18n/corrections-<lang>.json (optional, one per language pack: en, ja, ko, zh-TW): { "<raw Chinese data text>": "<translation>" }. It matches the raw text exactly; the plain twin (desc / effectDesc) is the stripped corrected raw text. Every entry has a _why: note. _-keys are skipped, so they never reach the overlay or the client (tools/ isn't served).
    • Coverage report: a new correction count. It counts as translated but not as official.
    • corrections-en.json holds the single Victoria entry. It fixes bonds.victoriaShip.effectDesc(Raw) and effects.bondeffect_victoria.desc(Raw) (4 strings). The new text is "[Victoria] Operators gain +50% ATK per equipment carried, or +80% per upgraded equipment".
    • data/i18n/en.json was rebuilt. Only those 4 strings changed.
    • Other languages translations aren't touched, since I cannot verify whether their translation also needs correction.
  • Expected result: An English player sees that two items give +100% ATK (+160% for two advanced items), as the engine applies it. JA / KO / zh-TW are unchanged: they have no corrections file, so their builds are the same as before.
  • Related issue / PR: None

Sources and assumptions

  • Sources:
    • Chinese data bonds.victoriaShip.effectDesc: 【维多利亚】干员每携带1件装备攻击力+50%,携带进阶装备改为+80% ("+50% ATK for each equipment carried, +80% instead for an advanced one").
    • Blackboard atk_normal_equip: 0.5, atk_golden_equip: 0.3.
    • server/sim/content/bonds/core.js installVictoria: adds atk_normal_equip per item, plus atk_golden_equip per golden item (0.5 / 0.8 per item, up to 2 items).
    • Official EN text from ArknightsAssets/ArknightsGamedata (en, act2autochess).
  • [ASSUMED]: None. "Upgraded" for 进阶装备 keeps the official EN client's own term.

Verification

  • Method: node tools/build-i18n.mjs --offline, then --check. Compared the en.json diff against the Chinese data and installVictoria.
  • Related tests: node --test test/i18n-data.test.js: tests 11, pass 11, fail 0. Two new tests: a correction wins over the official text, its plain twin is stripped, and a ko build reads its own corrections; and the shipped Victoria EN wording. test/i18n.test.js, i18n-packs.test.js, i18n-server.test.js and i18n-data.test.js together: tests 40, pass 40, fail 0 (run before the ko assertion was added).
  • build-i18n --check: data/i18n/en.json is up to date
  • npm run ci: setup, smoke, imports, typecheck ok · lint ok: 0 errors, 135 warnings (warnings allowed; none in the changed files) · test: 5968 tests, 5953 pass, 2 fail (perf benchmarks under full-suite load; all 3 pass when run alone: 142.4 / 282.6 / 471.7 µs/tick, bar 500), 13 skipped
  • npm run golden: ok, every scenario matches (roster 49, bonds 46, fields 22, matches 20, standins 10, diy 140)
  • Golden changes: None
  • Docs checks (test/docs-consistency.test.js, test/docs-paths.test.js): tests 31, pass 31, fail 0
  • Screenshots / recordings: N/A (text-only change)

Applicability

  • N/A items: Operator kit fidelity checklist, screenshots, docs/design/ and docs/history/ updates.
  • Reason: No operator kit, rule or UI change. The game behaviour is unchanged; only an EN text is corrected. The build pipeline change is documented in docs/I18N.md ("Corrections").
  • Not verified: JA / KO / zh-TW could not be rebuilt locally (their client tables aren't cached, and --offline fails). They load no corrections file, so their output is unchanged. Whether their official texts have the same Victoria issue wasn't checked.

Checklist

  • This PR covers one topic
  • Related tests, npm run ci and npm run golden have been run and the results are filled in truthfully
  • For rule changes, the docs are updated and the docs checks have been run
  • For operator kit changes: one operator only, with the Fidelity checklist ticked item by item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant