Repository navigation
Correct Victoria alliance effect EN translation via adding a correction layer to i18n - #499
Open
YuriRestia wants to merge 1 commit into
Open
YuriRestia wants to merge 1 commit into
YuriRestia wants to merge 1 commit into
Conversation
…ficial translation is wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Description
tools/build-i18n.mjs. It is tried before the official texts, so a wrong official line can be fixed without editing the official data.tools/i18n/corrections-<lang>.json(optional, one per language pack:en,ja,ko,zh-TW):{ "<raw Chinese data text>": "<translation>" }. It matches the raw text exactly; the plain twin (desc/effectDesc) is the stripped corrected raw text. Every entry has a_why:note._-keys are skipped, so they never reach the overlay or the client (tools/isn't served).correctioncount. It counts as translated but not as official.corrections-en.jsonholds the single Victoria entry. It fixesbonds.victoriaShip.effectDesc(Raw)andeffects.bondeffect_victoria.desc(Raw)(4 strings). The new text is "[Victoria] Operators gain +50% ATK per equipment carried, or +80% per upgraded equipment".data/i18n/en.jsonwas rebuilt. Only those 4 strings changed.Sources and assumptions
bonds.victoriaShip.effectDesc:【维多利亚】干员每携带1件装备攻击力+50%,携带进阶装备改为+80%("+50% ATK for each equipment carried, +80% instead for an advanced one").atk_normal_equip: 0.5,atk_golden_equip: 0.3.server/sim/content/bonds/core.jsinstallVictoria: addsatk_normal_equipper item, plusatk_golden_equipper golden item (0.5 / 0.8 per item, up to 2 items).Verification
node tools/build-i18n.mjs --offline, then--check. Compared theen.jsondiff against the Chinese data andinstallVictoria.node --test test/i18n-data.test.js: tests 11, pass 11, fail 0. Two new tests: a correction wins over the official text, its plain twin is stripped, and akobuild reads its own corrections; and the shipped Victoria EN wording.test/i18n.test.js,i18n-packs.test.js,i18n-server.test.jsandi18n-data.test.jstogether: tests 40, pass 40, fail 0 (run before thekoassertion was added).data/i18n/en.json is up to datetest/docs-consistency.test.js,test/docs-paths.test.js): tests 31, pass 31, fail 0Applicability
docs/design/anddocs/history/updates.docs/I18N.md("Corrections").--offlinefails). They load no corrections file, so their output is unchanged. Whether their official texts have the same Victoria issue wasn't checked.Checklist