Revert "Remove code that tries to handle ANSI escape inputs", prepare for v0.22.1 - #2308
Merged
Merged
Conversation
This reverts commit 8174e02. Turns out it is needed for a common use case, see sharkdp#2307. It is not a clean revert, because I adjust CHANGELOG.md and also add a comment to the test. I also had to resolve a small `use` conflict.
sharkdp
approved these changes
Sep 9, 2022
sharkdp
left a comment
Owner
There was a problem hiding this comment.
Thank you for taking such quick action!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8174e02. Turns out it is needed for a common use case, see #2307.
Closes #2307
Release checklist
Version bump
Cargo.toml. Runcargo buildto updateCargo.lock.Make sure to
git addtheCargo.lockchanges as well.Find the current min. supported Rust version by runninggrep '^\s*MIN_SUPPORTED_RUST_VERSION' .github/workflows/CICD.yml.Update the version and the min. supported Rust version inREADME.mdanddoc/README-*.md. Check withgit grep -i -e 'rust.*1\.' -e '1\..*rust' | grep README | grep -v tests/.CHANGELOG.md. Introduce a section for the new release.Update syntaxes and themes (build assets)
cargo clean && cargo install --locked -f --path .) and makesure that it is available on the
PATH(bat --versionshould show thenew version).
Runassets/create.shand check in the binary asset files.Documentation
Review-h,--help, and themanpage. All of these are shown inthe output of the CI job called Documentation, so look there.The CI workflow corresponding to the tip of the master branch is a good place to look.Pre-release checks
next section).
this, install the latest
batversion again (to include the new syntaxesand themes).
cargo publish --dry-runto make sure that it willsucceed later (after creating the GitHub release).
Release
git tag vX.Y.Z; git push origin tag vX.Y.Z.This will trigger the deployment via GitHub Actions.
REMINDER: If your
originis a fork, don't forget to push to e.g.upstreaminstead!release. Select the new tag and also use it as the release title. For the
release notes, copy the corresponding section from
CHANGELOG.mdandpossibly add additional remarks for package maintainers.
Publish the release.
appear when the CI run for the Git tag has finished).
cargo publishin a clean repository.The safest way to do this is to clone a fresh copy.
Post-release
CHANGELOG.md.Put this at the top: