Skip to content

feat: add cypher grammar#465

Merged
octref merged 2 commits into
shikijs:mainfrom
KevinBatdorf:add-cypher-lang
May 11, 2023
Merged

feat: add cypher grammar#465
octref merged 2 commits into
shikijs:mainfrom
KevinBatdorf:add-cypher-lang

Conversation

@KevinBatdorf

@KevinBatdorf KevinBatdorf commented May 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds the Cypher query language grammar (source)

The grammar mentions "fileTypes": ["cql", "cyp", "cypher"],. Should these be added somewhere as aliases perhaps?

  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@netlify

netlify Bot commented May 7, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit c2488e5
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/645d27496599e200085be05a
😎 Deploy Preview https://deploy-preview-465--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KevinBatdorf KevinBatdorf mentioned this pull request May 7, 2023
Closed
@octref

octref commented May 11, 2023

Copy link
Copy Markdown
Collaborator

In grammarSources.ts, you can find languageAliases. I think cql sounds reasonable. From my googling I didn't find any files with cyp suffix.

@KevinBatdorf

KevinBatdorf commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks here too, added that now. Good to check again when you're ready.

octref
octref approved these changes May 11, 2023
View reviewed changes

@octref octref left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@octref
octref merged commit dfc8283 into shikijs:main May 11, 2023
@Elenore23 Elenore23 mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octref octref octref approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KevinBatdorf @octref