feat: add hjson#471
Merged
Merged
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
octref
requested changes
May 22, 2023
octref
left a comment
Collaborator
There was a problem hiding this comment.
Just a small change needed. Thanks for your contribution!
| ['haml', 'https://github.com/karuna/haml-vscode/blob/master/syntaxes/haml.json'], | ||
| ['haskell', 'https://github.com/octref/language-haskell/blob/master/syntaxes/haskell.json'], | ||
| ['hcl', 'https://github.com/hashicorp/syntax/blob/main/syntaxes/hcl.tmGrammar.json'], | ||
| ['hjson', 'https://raw.githubusercontent.com/hjson/textmate-hjson/master/Syntaxes/Hjson.tmLanguage'], |
Collaborator
There was a problem hiding this comment.
Because of this:
shiki/scripts/util/download.ts
Lines 43 to 46 in 23dfa70
You can use the URL directly:
https://github.com/textmate/json.tmbundle/blob/master/Syntaxes/JSON.tmLanguage
octref
approved these changes
May 22, 2023
Collaborator
|
Looks great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test if possible
Format all commit messages with Conventional Commits
I have read docs for adding a language.
I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.