fix: Compiler errors in Node#504
Merged
Merged
Conversation
❌ Deploy Preview for shiki-matsu failed.
|
Contributor
Author
|
Deploy failures seems unrelated, I didn't change anything to do with node versions. |
Contributor
|
I've not thought too hard about this, but we did recently change this: #457 |
Contributor
Author
|
I could certainly change it so that this is a local type that is exported, and name it ResponseLike or something... so long as:
Then I'm happy |
octref
approved these changes
Jul 31, 2023
octref
left a comment
Collaborator
There was a problem hiding this comment.
Think that's good for now. In the new API I'm working on I'll avoid this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeDoc doesn't have "DOM" in the lib, so doesn't have a global
Responseinterface like DOM types do. The changes in #384 (cc @orta) broke me because it references that type now. This moves the interface into loader.ts so that it gets bundled in the declaration file output.