fix: mark connection connected after successful join - #248
Open
knownasrazi wants to merge 1 commit into
Open
knownasrazi wants to merge 1 commit into
knownasrazi wants to merge 1 commit into
Conversation
connect() moved the state to CONNECTING but never set CONNECTED once the session was ready, so the connection read as connecting forever. It now flips to CONNECTED after SESSION_READY is confirmed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection.connect()moves the state to CONNECTING but never sets CONNECTED once the session is ready, so a fully joined connection reads as connecting forever. That also makes a secondconnect()call return early as if a join were still in progress.It now flips to CONNECTED after SESSION_READY is confirmed. Failure paths are untouched and still reset to DISCONNECTED.
I verified it by driving a real Connection through a successful join with a stubbed connector: state stayed CONNECTING before, reads CONNECTED after.
tsc,oxfmt --checkandeslintall pass.