Skip to content

chore: mark legacy document domain as replaced by experimental document v2 - #20403

Merged
Lars Kemper (larskemper) merged 7 commits into
trunkfrom
chore/mark-legacy-document-domain-replaced
Sep 18, 2026
Merged

Lars Kemper (larskemper) merged 7 commits into
trunkfrom
chore/mark-legacy-document-domain-replaced

Conversation

@larskemper

@larskemper Lars Kemper (larskemper) commented Sep 14, 2026

Copy link
Copy Markdown
Member

resolves #20331

Changes

  • Add #[ExperimentalReplacement] BC-change attribute
  • Apply it to the 56 legacy classes under Shopware\Core\Checkout\Document
  • Convert the remaining marker usages to reason:remove-getter-setter and reason:remove-exception
  • Rewrite the v1 sections of RELEASE_INFO-6.7.md, UPGRADE-6.7.md, and UPGRADE-6.9.md

@larskemper
Lars Kemper (larskemper) requested review from Pierre02 and Jozsef Damokos (jozsefdamokos) and removed request for a team September 14, 2026 08:21
@larskemper Lars Kemper (larskemper) added the domain/crm-after-sales Responsible for all processes that are bundled and kicked off after the initial checkout label Sep 14, 2026
@larskemper Lars Kemper (larskemper) changed the title chore: mark legacy document domain as replaced by a experimental docu… chore: mark legacy document domain as replaced by experimental document v2 Sep 14, 2026
@larskemper
Lars Kemper (larskemper) force-pushed the chore/mark-legacy-document-domain-replaced branch from 6ed03a1 to cf3da5a Compare September 14, 2026 08:22
@larskemper
Lars Kemper (larskemper) marked this pull request as ready for review September 14, 2026 08:23
@shopware-octo-sts-app-2

Copy link
Copy Markdown
Contributor

cc @shopware/product-cc-after-sales

Comment thread UPGRADE-6.7.md Outdated
Comment thread adr/2026-08-05-document-generation-v1-to-v2-migration-strategy.md Outdated
Comment thread tests/unit/Core/DevOps/Test/AnnotationTagTesterTest.php
Comment thread src/Core/Checkout/DocumentV2/DocumentV2Exception.php Outdated
Comment thread src/Core/Checkout/Document/DocumentEntity.php Outdated
@github-actions github-actions Bot added the major/6.8 Collects all pull requests related to major release 6.8 label Sep 18, 2026
Comment thread src/Core/Checkout/Document/Service/DocumentGenerator.php
Comment thread src/Core/Content/Flow/Rule/OrderDocumentTypeRule.php
Comment thread src/Core/Framework/Feature.php
@shopware-octo-sts-app shopware-octo-sts-app Bot added the major-php Run major PHPUnit integration tests label Sep 18, 2026
@explore-openapi

explore-openapi Bot commented Sep 18, 2026

Copy link
Copy Markdown

OpenAPI Snapshot

ℹ️ shopware/store-api — schema identical to base trunk

ℹ️ shopware/admin-api — schema identical to base trunk

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.36%. Comparing base (f9984ab) to head (05e5ea0).
⚠️ Report is 39 commits behind head on trunk.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20403   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files        5769     5769           
  Lines      202431   202448   +17     
  Branches     9621     9621           
=======================================
+ Hits       140419   140433   +14     
- Misses      59204    59207    +3     
  Partials     2808     2808           
Flag Coverage Δ
phpunit-migration 95.03% <ø> (+0.01%) ⬆️
phpunit-unit 67.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@larskemper
Lars Kemper (larskemper) added this pull request to the merge queue Sep 18, 2026
Merged via the queue into trunk with commit 77fdedf Sep 18, 2026
104 checks passed
@larskemper
Lars Kemper (larskemper) deleted the chore/mark-legacy-document-domain-replaced branch September 18, 2026 13:34
Comment thread UPGRADE-6.7.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/documents domain/crm-after-sales Responsible for all processes that are bundled and kicked off after the initial checkout major/6.8 Collects all pull requests related to major release 6.8 major-php Run major PHPUnit integration tests milestone/6.7.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace hard deprecations on document refactor survivors with an attribute

6 participants