Skip to content

chore: Reorder arguments for default parameters - #20699

Open
Alex (lx-wnk) wants to merge 1 commit into
shopware:trunkfrom
lx-wnk:patch-2
Open

chore: Reorder arguments for default parameters#20699
Alex (lx-wnk) wants to merge 1 commit into
shopware:trunkfrom
lx-wnk:patch-2

Conversation

@lx-wnk

@lx-wnk Alex (lx-wnk) commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

1. Why is this change necessary?

It’s not necessary at all, but now the parameters are in the same order

2. What does this change do, exactly?

Reorders the parameters

3. Describe each step to reproduce the issue or behaviour.

/

4. Please link to the relevant issues (if any).

/

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have updated developer-facing release notes if this change is relevant for external developers:
    • Add a short entry to RELEASE_INFO-6.<major>.md under “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.
    • Add an UPGRADE section in UPGRADE-6.<next-major>.md for breaking changes (what/why/impact/how to adapt).
    • See the Documenting a Release Process for details.
  • I have written or adjusted the documentation and agent skills according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfilled them

@github-actions github-actions Bot added the external-contribution A PR contributed by a community member. label Sep 22, 2026
@lx-wnk

Alex (lx-wnk) commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

I have updated developer-facing release notes if this change is relevant for external developers

Wasn't sure if I should really note this change tbh. :D

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️ The Pull Request doesn't contain any release info, if your changes are relevant for external developers please add an entry to the release info file, including the consequences of the change and how it affects external developers. For detailed infos please refer to the [release documentation guide](https://github.com/shopware/shopware/blob/trunk/delivery-process/documenting-a-release.md).

@lx-wnk Alex (lx-wnk) changed the title Reorder arguments for default parameters chore: Reorder arguments for default parameters Sep 22, 2026
@explore-openapi

explore-openapi Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown

OpenAPI Snapshot

ℹ️ shopware/store-api — schema identical to base trunk

ℹ️ shopware/admin-api — schema identical to base trunk

@github-actions github-actions Bot added the needs-triage A newly created issue or PR that needs team assignment and/or prioritization. label Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

external-contribution A PR contributed by a community member. milestone/6.7.16.0 needs-triage A newly created issue or PR that needs team assignment and/or prioritization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lx-wnk