G12: Harvest Streak Counter - #1

tests/components/BankruptcyScreen.test.tsx (1)

100-108: ⚡ Quick win

Strengthen streak recap assertions beyond label presence.

Line 100 verifies headings only. Also assert streak values and the new-best badge so the new wiring is actually validated.

✅ Suggested assertions

-import { render, screen } from '`@testing-library/react`';
+import { render, screen, within } from '`@testing-library/react`';
@@
   it('shows Longest streak stat row with peakHarvestStreak', () => {
@@
     expect(screen.getByText('Longest streak')).toBeInTheDocument();
     expect(screen.getByText(/Best streak/i)).toBeInTheDocument();
+    expect(screen.getAllByLabelText('new personal best')).toHaveLength(1);
+    const recordsPanel = screen.getByLabelText(/personal records across all runs/i);
+    expect(within(recordsPanel).getByText('Best streak:')).toBeInTheDocument();
+    expect(within(recordsPanel).getByText('6')).toBeInTheDocument();
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/components/BankruptcyScreen.test.tsx` around lines 100 - 108, The test
currently only checks for the presence of the "Longest streak" and "Best streak"
labels; update the spec that uses renderScreen(...) (with peakHarvestStreak: 6,
records and newBests) to also assert the rendered numeric streak value (e.g.,
"6" or a string containing the peakHarvestStreak) and assert the "new best"
indicator is present when newBests includes 'bestHarvestStreak' so the wiring
for peakHarvestStreak and newBests is actually validated; locate the test using
renderScreen, peakHarvestStreak, records and newBests and add assertions for the
streak number and the new-best badge element.

tests/components/HUD.test.tsx (1)

71-76: ⚡ Quick win

Add a tooltip/cap assertion for the streak chip.

Line 71 currently validates visibility/text only. Add a title assertion so capped next-bonus behavior is protected too.

✅ Suggested test extension

   it('shows the streak chip with ×N when harvestStreak > 0', () => {
     render(<HUD {...baseProps} currentDay={5} coinBalance={100} harvestStreak={7} />);
     const chip = screen.getByLabelText(/harvest streak/i);
     expect(chip).toBeInTheDocument();
     expect(chip).toHaveTextContent('×7');
+    expect(chip).toHaveAttribute('title', expect.stringMatching(/\+20🪙 bonus \(capped at \+20\)/i));
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/components/HUD.test.tsx` around lines 71 - 76, The test "shows the
streak chip with ×N when harvestStreak > 0" in HUD.test.tsx should also assert
the streak chip's tooltip/cap behavior: after rendering HUD with harvestStreak
(the existing render call using HUD and props like currentDay, coinBalance,
harvestStreak), grab the chip via getByLabelText(/harvest streak/i) (the
existing chip variable) and add an assertion that the chip has a title attribute
(and, if you know the exact capped message, assert its value) — e.g.
expect(chip).toHaveAttribute('title') or
expect(chip.getAttribute('title')).toBe('EXPECTED_TOOLTIP') to protect the
capped next-bonus behavior.

tests/engine/gameEngine.test.ts (1)

1534-1546: ⚡ Quick win

This season_failed test never exercises the streak-preservation path.

Here the turn has no harvest, so the streak becomes 0 even without any season-end reset. The test would still pass if season_failed incorrectly cleared a harvested streak. Use a season-end turn that harvests but still misses the target.

Example adjustment

-  it('does NOT reset streak on season_failed (run is ending)', () => {
-    const base = {
-      ...initialGameState(),
-      currentDay: 20,
-      coinBalance: 16,
-      harvestStreak: 2,
-      peakHarvestStreak: 2,
-    };
-    const { state: after, log } = processTurn(base, 'sunny');
+  it('does NOT reset streak on season_failed when the final turn harvests', () => {
+    const seeded = seedAndPlant({
+      ...initialGameState(),
+      currentDay: 20,
+      coinBalance: 21,
+      harvestStreak: 2,
+      peakHarvestStreak: 2,
+    });
+    const { state: after, log } = processTurn(seeded, 'sunny');
     expect(after.phase).toBe('season_failed');
-    expect(log.streakAfter).toBe(0); // no harvest → miss-day reset (independent rule)
-    expect(after.harvestStreak).toBe(0);
+    expect(log.streakBefore).toBe(2);
+    expect(log.streakAfter).toBe(3);
+    expect(after.harvestStreak).toBe(3);
   });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/engine/gameEngine.test.ts` around lines 1534 - 1546, The test "does NOT
reset streak on season_failed (run is ending)" currently uses a turn with no
harvest so the streak resets for an unrelated reason; change the base state in
this test so the turn produces a harvest but still results in phase
'season_failed' (so we exercise the season-end code path). In practice, adjust
the initialGameState() seed values (e.g., crop/harvest readiness or coinBalance)
used in the test before calling processTurn('sunny') so processTurn returns
after.phase === 'season_failed' while a harvest occurred, then assert that
after.harvestStreak and log.streakAfter preserve the pre-turn streak
(harvestStreak remains 2). Target the test case, initialGameState(),
processTurn, and the assertions around after.phase, log.streakAfter and
after.harvestStreak.

tests/engine/records.test.ts (1)

157-158: ⚡ Quick win

Use the imported constant instead of hardcoded string.

Line 158 uses the hardcoded string 'pixel-parsnips-records' instead of the imported RECORDS_KEY constant. Line 67 in this file correctly uses the constant. Using the constant prevents maintenance issues if the key value changes.

♻️ Proposed fix

-    localStorage.setItem(
-      'pixel-parsnips-records',
+    localStorage.setItem(
+      RECORDS_KEY,
       JSON.stringify({

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/engine/records.test.ts` around lines 157 - 158, Replace the hardcoded
localStorage key string with the imported RECORDS_KEY constant: in the test
where localStorage.setItem('pixel-parsnips-records', ...) is used, swap the
literal for RECORDS_KEY and ensure the test imports/uses the same RECORDS_KEY
referenced earlier in this file (the constant used at line 67) so both
occurrences consistently use RECORDS_KEY.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes