Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

(SIMP-1274) Add SIMP-default LDAP data - #1

Merged
trevor-vaughan merged 2 commits into
simp:masterfrom
lamawithonel:SIMP-1274
Aug 5, 2016
Merged

trevor-vaughan merged 2 commits into
simp:masterfrom
lamawithonel:SIMP-1274

Conversation

@lamawithonel

Copy link
Copy Markdown
Member

This adds default data for the SIMP-standard OpenLDAP server using the SIMP-standard ldap::* Hiera keys. By default LDAP remains disabled, but enabling it in the cfg parameter will configure it for use in a default SIMP environment.

Also included in this PR is a commit to refactor the acceptance tests' use of Hiera data via the new simp-beaker-helpers method #write_hieradata_to.

This refactors the acceptance tests to use shared default Hiera data.
@trevor-vaughan

Copy link
Copy Markdown
Member

This looks good with one exception.

Can you make the activation of the LDAP capability dependent on the global catalyst use_ldap like in https://github.com/simp/pupmod-simp-simp/blob/master/manifests/init.pp#L101 ?

This way, it will match the rest of the SIMP environment.

This adds default data for the SIMP-standard OpenLDAP server using the
SIMP-standard `ldap::*` Hiera keys.  By default LDAP remains disabled,
but enabling it in the `cfg` parameter will configure it for use in a
default SIMP environment.
@trevor-vaughan
trevor-vaughan merged commit a384a87 into simp:master Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants