-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
Add NativeScript #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add NativeScript #3529
Conversation
|
👋 It looks like you've missed at least a couple of checklist items, including the one flagged by the CI failure. Please could you re-review the checklist and make the necessary changes? Thanks I also can't see any existing PRs that you've reviewed. I appreciate that this can be a difficult requirement since others often get in first with a review, and adding a detailed review involves finding a PR that requires one, but see what you can do. |
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
I will try to fix it |
|
unicorn |
|
Well spotted about one of the missing items 🦄 . You've still got failing CI so I won't re-review until that's passing. |
CI passed, unicorn |
Co-authored-by: Sam Partington <sampart@github.com>
sampart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being responsive to feedback here ✨
Yeah, that is a good feedback 👍 |
Mo-way
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dyazincahya
Still missing:
This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
Also not sure about the "at the bottom" requirement.
Okay, I have renamed the pull request title. |
Good! No need for evidence image, I can see it :D
I assume you put the entry where it is, instead of on the bottom, because the topic matches. Personally, I'd say it's fine, let's see what Sindre says. |
|
I'm not into Javascript, so take it with a grain of salt: Been looking at the list and the Same goes for components. |
Thank you for the feedback! Actually, many people may not realize that the plugins in the main NativeScript repository are grouped into a single monorepo, which makes them a bit difficult to discover individually. That’s why I’ve tried to categorize the plugins and components based on their functionality — to make them easier to find and use. Just to briefly share a bit of NativeScript’s history as I understand it: NativeScript was originally developed by Telerik, which is part of the Progress company. Back then, many community members contributed by developing plugins to support the NativeScript ecosystem. Around 2018–2019, NativeScript was officially handed over to the community — including the website, repositories, and ongoing development. Since then, the community has taken the lead in managing and evolving the project. Since that transition, many plugins and components created by the community were moved into the main NativeScript and nativescript-community repositories, so they could be maintained in a more centralized and collaborative way. However, plugin curation and categorization are still somewhat limited. A few individuals or organizations actively maintain their own plugin repositories, but to my knowledge, they are relatively few. Currently, there are two main repositories, both maintained by the community:
|
0abcf16 to
393b934
Compare
ded208d to
62ee821
Compare
Description should not repeat the title Some items are missing descriptions: https://github.com/dyazincahya/awesome-nativescript?tab=readme-ov-file#unit-testing |
Done, I've fix it |
https://github.com/dyazincahya/awesome-nativescript
A curated list of awesome plugins, and resources for NativeScript.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List. It should not contain the wordAwesome.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Awesome Xand a logo withAwesome X. You can put the header image in a#(Markdown header) or<h1>.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. The casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.