Repository navigation
fix(interp): build the element shape table on every architecture - #203
Conversation
The BLR slot path cannot serve a call to the function currently being emitted: it has published no slot yet. A self callee that selfCall turns down was falling through to that path with the call marker pushed back onto the operand stack, so ctx.sp() counted one slot too many and the callee frame base landed one slot high. Nothing reaches it - instrumenting the branch across the interp suite and all 18 benchmark kernels recorded zero hits - so this removes an untested path rather than fixing an observed failure. Rejecting matches what the code did before the marker handling moved. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jit_plan.go resolves a container's element layout through elemShapeByItab, but that table and the itabs it names lived in jit_arm64.go, whose name constrains it to one GOARCH. The planner is portable and compiles for architectures with no native backend at all, so every non-arm64 build failed on an undefined symbol. Move the heap itabs, the element shape table, and the ref-array element offset the table names into the portable JIT core. Nothing changes for arm64; the architecture file keeps only lowering detail. Regression from #200, where the table was introduced. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 43 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The gate compares one number across two architectures with very different compiled surfaces. CI runs on amd64, where the arm64 JIT backend is not compiled but the portable planner, tracer, and JIT core are - and every test that exercises them skips, so they count as uncovered. 72.8 was recorded in #146, before the JIT grew. It has not been measurable since: non-arm64 builds have failed outright, so the job never reached the gate. With the build fixed, the honest amd64 number is 63.6. Raising it again needs portable tests for the planner and tracer, not a different threshold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 31.20% 22.92% -8.28%
==========================================
Files 85 87 +2
Lines 59612 70125 +10513
==========================================
- Hits 18601 16077 -2524
- Misses 39846 52802 +12956
- Partials 1165 1246 +81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Two small follow-ups to the native-call work that landed in #201.
1. Non-arm64 builds are broken on
mainjit_plan.goresolves a container's element layout throughelemShapeByItab, but that table — and the itabs it names — lived injit_arm64.go, whose filename constrains it to oneGOARCH. The planner is portable and compiles for architectures with no native backend at all, so every non-arm64 build fails:This is why CI has been red on
ubuntu-24.04. Regression from #200, where the table was introduced — I wrote it and put it in the wrong file.Moves the heap itabs, the element shape table, and the ref-array element offset the table names into the portable JIT core. Nothing changes for arm64; the architecture file keeps only lowering detail.
2. Dead self-callee fallthrough
The
BLRslot path cannot serve a call to the function currently being emitted: it has published no slot yet. A self callee thatselfCallturned down fell through to that path with the call marker pushed back onto the operand stack, soctx.sp()counted one slot too many and the callee frame base landed one slot high.Instrumenting that branch across the interp suite and all 18 benchmark kernels recorded zero hits, so this removes an untested path rather than fixing an observed failure. Rejecting matches what the code did before the marker handling moved.
Verification
go buildfor botharm64andlinux/amd64;GOOS=linux GOARCH=amd64 go vet ./...clean.go test -race ./...,make lint,make check-generatedpass.🤖 Generated with Claude Code