Repository navigation
fix(interp): release the operand coro.done pops - #336
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
CORO_DONE replaced its reference operand with an i1 without releasing it, so every check leaked one count on the iterator or coroutine it tested. CORO_VALUE already released its operand. The JIT bridge retains each operand before running the handler, so the release balances there too. Fixes #331 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
siyul-park
force-pushed
the
fix/coro-done-release
branch
from
November 12, 2026 09:31
0c7a61b to
db2a797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CORO_DONEreplaced its reference operand with thei1result but never released that operand, so each check leaked one count on the iterator or coroutine it tested.CORO_VALUEalready released its operand. The handler, in the codegen generator and regenerated ininterp/threaded.go, now releases it.On ARM64,
CORO_DONEbridges. The bridge retains each ref operand before running the handler and releases only the operands the op adopts, andCORO_DONEadopts none. The handler's release therefore balances the bridge's retain.Fixes #331.
Evidence
TestInterpreter_Run/coro.done releases the reference it popswalks a 5-entry map withmap.iterand checks the heap counts afterwards:Validation
go test ./...cd benchmarks && go test ./... -run TestKernelsmake check-generatedmake check(pre-commit)git diff --check🤖 Generated with Claude Code