fix: MINIDUMP_EXCEPTION parsing - #38
Merged
Merged
Conversation
Owner
|
Cool! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A friend of mine was trying this library because he needs to parse some minidumps for a private project. Everything worked fine, except for the
MINIDUMP_EXCEPTIONparsing. Since the code wasn't actually considering the size ofExceptionInformation, it was leading to incorrect parsing ofThreadContextfromMINIDUMP_EXCEPTION_STREAM.Solution
Very simple! Just read the entire field and then copy the actual parameters, which is what this PR achieves.