Skip to content

Conversation

@stagg
Copy link
Collaborator

@stagg stagg commented Jul 26, 2025

Changes

  • Change to use the compose multi-platform view model
  • Moved ViewModelBackStackRecordLocalProvider into circuit foundation out of backstack
    • Think it makes more sense for this to exist within foundation?
    • Allows for using circuit retained instead of fishing for an Activity
  • Provide the ViewModelBackStackRecordLocalProvider as default on the circuit instance instead of as a static val
    • Now allows for setting default BackStackRecordLocalProvider's
  • Add backStackHostViewModel() to allow access to a ViewModel in the host of the NavigableCircuitContent

@stagg stagg changed the title backstack view model provider rework Rework ViewModelBackStackRecordLocalProvider Jul 29, 2025
@stagg stagg marked this pull request as ready for review July 29, 2025 01:28
@stagg stagg requested a review from ZacSweers July 29, 2025 01:28
@stagg stagg added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 309a401 Jul 29, 2025
5 checks passed
@stagg stagg deleted the j-move-backstack-localproviders branch July 29, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants