fix(vscode): fix line number decorations, upgrade reactive-vscode#2418
Merged
Conversation
❌ Deploy Preview for slidev failed.
|
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the reactive-vscode library from v0.4.1 to v1.0.0-beta.1, adapting to breaking changes in the new version. The upgrade primarily affects the configuration system and various API functions, requiring updates across multiple files.
- Migrated from
defineConfigstodefineConfigwith a new access pattern for configuration values - Updated several reactive-vscode API functions (e.g.,
useLogger→defineLogger,useFsWatcher→useFileSystemWatcher,forceRefresh→forceReload) - Refactored terminal management in dev server to use manual creation instead of
useControlledTerminal
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates reactive-vscode version specification in catalog from ^0.4.1 to ^1.0.0-beta.1 |
| pnpm-lock.yaml | Updates lockfile with new reactive-vscode version, dependencies, and removes libc constraints from various platform-specific packages |
| packages/vscode/src/configs.ts | Completely refactors config system from defineConfigs to defineConfig with typed interface |
| packages/vscode/src/views/logger.ts | Updates logger initialization from useLogger to defineLogger |
| packages/vscode/src/views/slidesTree.ts | Removes useViewVisibility in favor of accessing treeView.visible.value directly |
| packages/vscode/src/views/previewWebview.ts | Updates config access pattern and renames forceRefresh to forceReload |
| packages/vscode/src/views/annotations.ts | Simplifies by removing debounced line number updates and using direct config access |
| packages/vscode/src/projects.ts | Migrates from useFsWatcher to useFileSystemWatcher with new callback-based API |
| packages/vscode/src/composables/useServerDetector.ts | Updates config access to use new pattern |
| packages/vscode/src/composables/useFocusedSlide.ts | Adds defensive null check for selection value |
| packages/vscode/src/composables/useDevServer.ts | Replaces useControlledTerminal with manual terminal creation and updates path helper from useAbsolutePath to useAbsoluteUri |
| packages/vscode/src/commands.ts | Updates all config access and update calls to use new API pattern |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
antfu
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactive-vscode v1.0.0-beta.1 was released with a lot of improvements (especially
defineConfig) and breaking changes.