fix: prevent square brackets in code from being parsed as title#2419
Merged
antfu merged 1 commit intoJan 7, 2026
Merged
Conversation
Fixes an issue where square brackets on the first line of code blocks (e.g., `[Flags]` attribute in C#) were incorrectly interpreted as block titles. Changed regex to only match spaces and tabs (not newlines) on the opening line.
❌ Deploy Preview for slidev failed.
|
kermanx
approved these changes
Jan 1, 2026
antfu
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where square brackets on the first line of code blocks were incorrectly interpreted as block titles.
For example, C# attributes like
[Flags]at the beginning of code blocks were being parsed as the title instead of being treated as part of the code content.Changes
code-wrapper.tsto only match spaces and tabs (not newlines) on the opening line\s*to[ \t]*to prevent matching newlines before parsing optional title bracketsTest Cases
[Flags]stays in codeBefore (Current Behavior)
The first test case incorrectly extracts
[Flags]as the title:Visual Example
The following C# code demonstrates the issue:
Before the fix: