feat(client): expose preloadProgress / preloadComplete from the image preloader#2650
Merged
Merged
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
quinnypig
marked this pull request as ready for review
June 25, 2026 03:12
…ge preloader Expose reactive preloadProgress (0..1) and preloadComplete from usePreloadImages so a deck or theme can show a 'preloading...' indicator or gate on full preload. Total counts the unique slide images across the deck; progress tracks how many have loaded.
quinnypig
force-pushed
the
feat/preload-progress
branch
from
June 25, 2026 06:27
000be90 to
41bb386
Compare
antfu
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose reactive
preloadProgress(0–1) andpreloadCompletefromusePreloadImages, so a deck or theme can show a "preloading…" indicator — or gate something on full preload, which is handy before presenting on a flaky/absent connection.preloadProgress= unique slide images loaded / total unique slide images in the deck (1 when the deck has no images).preloadComplete=preloadProgress >= 1.Consumable via
import { preloadProgress, preloadComplete } from '@slidev/client/composables/usePreloadImages'. No change to the package's public index, so no API-surface churn.Verification
pnpm build+pnpm test+pnpm typecheck+pnpm lintall pass.