Skip to content

fix(server): 404 on out-of-range slide patch - #2704

Merged
antfu merged 1 commit into
slidevjs:mainfrom
NgoQuocViet2001:fix-slide-patch-bounds
Sep 15, 2026
Merged

antfu merged 1 commit into
slidevjs:mainfrom
NgoQuocViet2001:fix-slide-patch-bounds

Conversation

@NgoQuocViet2001

Copy link
Copy Markdown
Contributor

Summary

  • return 404 when the slide editor requests an index outside the current deck
  • reuse the validated slide in both GET and POST handling
  • prevent a stale editor save from dereferencing a missing slide and terminating the dev server
  • complete the repository's plan 011 tracking

Tests

  • pnpm build
  • pnpm typecheck
  • pnpm test (27 files, 229 tests)
  • pnpm exec eslint packages/slidev/node/vite/loaders.ts
  • manually verified valid GET returns 200, out-of-range GET and POST return 404, and the server remains responsive after the invalid POST

@netlify

netlify Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 94f25bc
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/6a7ed50c47d2570008dcf3ef
😎 Deploy Preview https://deploy-preview-2704--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/@slidev/client@2704

create-slidev

npm i https://pkg.pr.new/create-slidev@2704

create-slidev-theme

npm i https://pkg.pr.new/create-slidev-theme@2704

@slidev/parser

npm i https://pkg.pr.new/@slidev/parser@2704

@slidev/cli

npm i https://pkg.pr.new/@slidev/cli@2704

@slidev/types

npm i https://pkg.pr.new/@slidev/types@2704

commit: 94f25bc

@antfu
antfu merged commit 3cbc4f6 into slidevjs:main Sep 15, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants