Repository navigation
fix: keep c#, c++ and f# languages in code blocks and magic move - #2760
Merged
Merged
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code block info regex only accepts
[\w'-]for the language, so```c# [Program.cs] {1}is parsed as langcplus a leftover#. The block gets the C grammar (<code class="language-c">) and also loses its title and ranges (title="",:ranges='[]').c++ends up asctoo, andf#becomesf, which Shiki resolves to Fortran. This started in v52.15.0, when wrapping moved into the fence renderer. Before that, the markdown transform skipped these blocks and Shiki still gotc#.Magic Move has used the same character class for longer. A
c#orc++step never matches, so a block with only those steps throws "Magic Move block must contain at least one code block", and in a mixed block the step is silently dropped (```ts+```c#gives only['ts']).This adds
#and+to the language group in both regexes, the same kind of change #1389 made with-forangular-ts. It covers Shiki'sc#,c++andf#aliases.pnpm vitest run packages/slidev/node/syntax/codeblock. Both new tests fail on main (the Magic Move error, andlanguage-cwith an empty title) and pass with the change.vitest test --run(thepnpm testscript) after a fresh build: 34 files and 379 tests passed.pnpm lintandpnpm typecheck: both clean.